From caef84a898c786fcde190d8089874ee7cb74f271 Mon Sep 17 00:00:00 2001 From: "kfraser@localhost.localdomain" Date: Tue, 5 Jun 2007 09:59:34 +0100 Subject: [PATCH] qemu: Use domid in qemu log name. Can be related back to domain name or uuid via xend logs, less unique than pids to prevent excessive number of log files hanging around, yet not immediately reused (unlike e.g., after domain crash or reboot) where previous log file is immediately overwritten. Not using domain names in logs avoids and chance of unprintable charcatres becoming embedded in filenames. Signed-off-by: Keir Fraser --- tools/ioemu/vl.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tools/ioemu/vl.c b/tools/ioemu/vl.c index 7de0d86da1..5458684f3e 100644 --- a/tools/ioemu/vl.c +++ b/tools/ioemu/vl.c @@ -183,7 +183,7 @@ extern int vcpus; int xc_handle; -char domain_name[64] = "Xen HVM Guest"; +char domain_name[64] = "Xen-HVM-no-name"; extern int domid; char vncpasswd[64]; @@ -7525,8 +7525,8 @@ int main(int argc, char **argv) semihosting_enabled = 1; break; case QEMU_OPTION_domainname: - strncpy(domain_name, optarg, sizeof(domain_name)); - domain_name[sizeof(domain_name)-1] = '\0'; + snprintf(domain_name, sizeof(domain_name), + "Xen-HVM-%s", optarg); break; case QEMU_OPTION_d: domid = atoi(optarg); @@ -7550,7 +7550,7 @@ int main(int argc, char **argv) } /* Now send logs to our named config */ - sprintf(qemu_dm_logfilename, "/var/log/xen/qemu-dm-%s.log", domain_name); + sprintf(qemu_dm_logfilename, "/var/log/xen/qemu-dm-%d.log", domid); cpu_set_log_filename(qemu_dm_logfilename); #ifndef _WIN32 -- 2.30.2